Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIOD 2016 and new format for WIOD2013 #3

Merged
merged 4 commits into from
Feb 7, 2017
Merged

Conversation

zauster
Copy link
Contributor

@zauster zauster commented Feb 4, 2017

Hey,

here are the functions that allow access to the new 2016 version of the WIOD.

Additionally, a new format for the tables of the WIOD 2013, as discussed in #2.
I also moved the package and data documentation in separate files.

Best,
Oliver

@bquast
Copy link
Owner

bquast commented Feb 6, 2017

Hey, sorry just looking at this now. I was away for the weekend. Looks like a lot of work in this.

@bquast
Copy link
Owner

bquast commented Feb 6, 2017

Ok, I am going to look at this in detail now, though I am sure it can be merged as is.

Only thought, from the updated examples, maybe we should update decompr so that it can simply take one iot object?

@zauster
Copy link
Contributor Author

zauster commented Feb 6, 2017

Sure, let's do that.

@bquast
Copy link
Owner

bquast commented Feb 6, 2017

Ok, let me see if I can find a way to do this with backward compatibility

@bquast
Copy link
Owner

bquast commented Feb 6, 2017

In any case, for that we will need to add the class to these objects. Something like:

class(wiot_1995) <- 'iot'

@bquast
Copy link
Owner

bquast commented Feb 6, 2017

we also might want to see if there is a way to load data.table silently

@bquast
Copy link
Owner

bquast commented Feb 6, 2017

Ok, I did this:

bquast/decompr@9f3bb50

which seems to work. what do you think? we'd have to add class(obj) <- 'iot' to all objects.

@zauster
Copy link
Contributor Author

zauster commented Feb 7, 2017

I'll add the class attribute

@bquast
Copy link
Owner

bquast commented Feb 7, 2017

thanks! lets leave this as is for a bit, ill try and clean up the rstudio addin for decompr and get everything on cran, then we can also update this one on cran

@bquast bquast merged commit e957ed7 into bquast:master Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants