Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new tool hrtimersnoop #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

makelinux
Copy link

The tool attaches to timer tracepoints hrtimer_expire_entry, hrtimer_expire_exit and measures delay of timer expiration and duration of timer handler execution.

@jordalgo
Copy link
Contributor

jordalgo commented Apr 4, 2024

@danobi @ajor @viktormalik - Should the instruction/description file with these scripts be in markdown?

@makelinux makelinux force-pushed the hrtimersnoop branch 2 times, most recently from bfef2e9 to d93fc55 Compare April 5, 2024 05:37
Copy link
Member

@ajor ajor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution - I'm sure we will be merging it at some point soon.

I'm just putting a temporary block on it while we have a discussion about licences for this new repository.

Copy link
Member

@ajor ajor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in getting back to you. We're going to request that new scripts be licensed under a GPLv2-compatible license so that they are able to use the full BPF functionality by calling into GPL-only functions in the Linux kernel.

The list of accepted licenses is described in the kernel docs here: https://docs.kernel.org/process/license-rules.html#id1

  • GPL v2
  • Dual MIT/GPL v2
  • Dual BSD/GPL v2
  • Dual MPL/GPL v2

We're also going to start using SPDX identifiers to avoid large license boilerplate. An example would be:

// SPDX-License-Identifier: GPL-2.0-or-later

or:

// SPDX-License-Identifier: MIT OR GPL-2.0-or-later

Copy link
Member

@ajor ajor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry again, we should have had our contribution guidelines set up before opening up this repository.

* Copyright 2024 Red Hat, Inc.
* Licensed under the Apache License, Version 2.0 (the "License").
*
* 4-Apr-2024 Costa Shulyupin Initial release
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're also not going to maintain a pseudo-changelog in the script headers in this repository as it's not a reliable source of information (some people update it, some don't) and to avoid debates on what changes are worth including. The Git logs should provide a complete history.

The copyright notice will of course remain.

Suggested change
* 4-Apr-2024 Costa Shulyupin Initial release

The tool attaches to timer tracepoints hrtimer_expire_entry,
hrtimer_expire_exit and measures delay of timer expiration
and duration of timer handler execution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants