Skip to content

Commit

Permalink
Makefile: Export BPFMAN_AGENT_IMG and BPFMAN_OPERATOR_IMG
Browse files Browse the repository at this point in the history
Ensure BPFMAN_AGENT_IMG and BPFMAN_OPERATOR_IMG are exported so that
they are available to child processes invoked by make. The Makefile
provides helpful default values for these variables if not specified.
However, without exporting them, you must either specify the values on
the make invocation line or export them from your shell. This change
resolves issues where integration tests fail due to these variables
being missing from the environment.

Signed-off-by: Andrew McDermott <[email protected]>
  • Loading branch information
frobware committed Jul 26, 2024
1 parent e9dd1db commit 97119e5
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,11 @@ BPFMAN_AGENT_IMG ?= quay.io/bpfman/bpfman-agent:$(IMAGE_TAG)
BPFMAN_OPERATOR_IMG ?= quay.io/bpfman/bpfman-operator:$(IMAGE_TAG)
KIND_CLUSTER_NAME ?= bpfman-deployment

# These environment variable keys need to be exported as the
# integration tests expect them to be defined.
export BPFMAN_AGENT_IMG
export BPFMAN_OPERATOR_IMG

# ENVTEST_K8S_VERSION refers to the version of kubebuilder assets to be downloaded by envtest binary.
ENVTEST_K8S_VERSION = 1.25.0
K8S_CODEGEN_VERSION = v0.30.1
Expand Down

0 comments on commit 97119e5

Please sign in to comment.