Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issues #2783 #1943 #1509 #2017 and #2298 #2785

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

fe-cj
Copy link
Contributor

@fe-cj fe-cj commented Sep 11, 2024

  • Fixes #2783, now margins of nodes with relativePosition or absolutePosition are ignored and don't interfere with the regular flow of the layout.
  • Fixes #1943 #1509 #2017 and #2298: They are all the same bug, the problem was that when a page break was produced and there was a snapshot stored (columns or tables; detached blocks also generate a snapshot but since we are ignoring their margins now, no need to do anything), it was calculating the new available width of the top parent snapshot without taking into consideration the lateral margins of the node that produced the snapshot.
  • It also fixes a small bug introduced by PR #1402 that made the code not to apply the lateral margins of a node after a page break was produced by its margins.

@liborm85 liborm85 merged commit 3fec81c into bpampuch:master Sep 13, 2024
6 checks passed
@liborm85
Copy link
Collaborator

Excellent work, thanks.

liborm85 added a commit that referenced this pull request Sep 13, 2024
@fe-cj
Copy link
Contributor Author

fe-cj commented Sep 13, 2024

It also fixes #2671

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants