Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #1042 #2778

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Fixes issue #1042 #2778

merged 3 commits into from
Sep 5, 2024

Conversation

fe-cj
Copy link
Contributor

@fe-cj fe-cj commented Sep 3, 2024

Fixes #1042

It was not calculating correctly the 'y' at the end of a rowSpan with dontBreakRows.

@liborm85
Copy link
Collaborator

liborm85 commented Sep 4, 2024

PR is in conflict with PR #2775.

@fe-cj
Copy link
Contributor Author

fe-cj commented Sep 4, 2024

Ok, will solve the conflicts later.

@fe-cj
Copy link
Contributor Author

fe-cj commented Sep 4, 2024

Done

@liborm85 liborm85 merged commit aff4a14 into bpampuch:master Sep 5, 2024
6 checks passed
@liborm85
Copy link
Collaborator

liborm85 commented Sep 5, 2024

Cool. Merged. Thanks.

liborm85 added a commit that referenced this pull request Sep 5, 2024
@fe-cj
Copy link
Contributor Author

fe-cj commented Sep 7, 2024

It also fixes #2452

@Phi-Hung-1007
Copy link

call dontBreakRows: true,
bug :
image

@fe-cj
Copy link
Contributor Author

fe-cj commented Sep 27, 2024

@Phi-Hung-1007 Can you please share a doc definition that we can use on the playground to reproduce the bug? Thanks.

@Phi-Hung-1007
Copy link

Phi-Hung-1007 commented Sep 27, 2024

@fe-cj On the playgound, I use dontBreakRows to avoid breaking rowspan between two pages but still get it, it seems like version 2.0.13 is not applied on playground yet? Thanks
image

@liborm85
Copy link
Collaborator

On playground is latest version 0.2.13.

@Phi-Hung-1007
Copy link

Phi-Hung-1007 commented Sep 27, 2024

@liborm85 So why can't I still use dontBreakRows for rowSpan like in the example above?

@fe-cj
Copy link
Contributor Author

fe-cj commented Sep 28, 2024

dontBreakRows applies to single rows, not to rowspanned rows.

@Phi-Hung-1007
Copy link

Phi-Hung-1007 commented Sep 28, 2024

Oh I thought you fixed the dontBreakRows with rowSpan error in the above issue. But when I updated to version 0.2.13 I couldn't even call dontBreakRows with single row because of the error in the first comment.
Ảnh chụp màn hình 2024-09-29 065101

@fe-cj
Copy link
Contributor Author

fe-cj commented Sep 29, 2024

I fixed an error that was adding extra height to the table when combining rowSpan with dontBreakRows.

If you encounter a bug, it would be nice if you open an issue and share a doc definition that others can copy and paste in the playground.

@Phi-Hung-1007
Copy link

On the playground, I can't reproduce the error I get in IDE when installing version 0.2.13 and calling dontBreakRows: true
On the Playground:
image
On my IDE:
image

@liborm85
Copy link
Collaborator

@Phi-Hung-1007 Again... If you found bug, open an issue with example code for reproduce problem runnable on playground or https://jsfiddle.net/ or a similar service, as is described in CONTRIBUTING.md.
Screenshots are not runnable on playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange column length when using colSpan & rowSpan
3 participants