max_zoom and default tiles #234
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
|
Made some changes. Let me know what you think @hupe13 |
| 'default'=>'18', | ||
| 'type' => 'number', | ||
| 'helptext' => sprintf( | ||
| '%1$s %2$s <br/> <code>[leaflet-map map_tile_maxzoom="1234"]</code>', |
There was a problem hiding this comment.
probably should use a better example maxzoom than "1234"; sorry I missed this on my first pass
shortcodes/class.map-shortcode.php
Outdated
| @@ -199,10 +199,9 @@ protected function getAtts($atts='') | |||
| 'accessToken' => empty($accesstoken) ? $settings->get('accesstoken') : $accesstoken, | |||
| 'zoomOffset' => empty($zoomoffset) ? $settings->get('zoomoffset') : $zoomoffset, | |||
| 'noWrap' => filter_var(empty($nowrap) ? $settings->get('tile_no_wrap') : $nowrap, FILTER_VALIDATE_BOOLEAN), | |||
| 'maxZoom' => $atts['maxZoom'] | |||
| 'maxZoom' => filter_var(empty($map_tile_maxzoom) ? $settings->get('map_tile_maxzoom') : $map_tile_maxzoom, FILTER_VALIDATE_FLOAT), | |||
There was a problem hiding this comment.
map var should only apply to the tile layer options, and should be filtered
|
Kudos, SonarCloud Quality Gate passed!
|
| } | ||
| }); | ||
| }); | ||
| '; |
There was a problem hiding this comment.
I have no idea what this is, but it doesn't look right
There was a problem hiding this comment.
I tried to prevent that the zoom of the map greater or smaller is as the possible tiles zoom.
|
Kudos, SonarCloud Quality Gate passed!
|
|
|
#232 (comment)