Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support licen(c|s)e-apache #543

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

spenserblack
Copy link
Contributor

It's a pretty common filename: https://github.com/search?q=path%3A%2F%28%5E%7C%5C%2F%29LICEN%28S%7CC%29E-APACHE%24%2F&type=code

You'll often see it in Rust projects, which are often MIT/Apache-2.0 dual-licensed.

@boyter boyter merged commit e2d6639 into boyter:master Oct 22, 2024
5 checks passed
@boyter
Copy link
Owner

boyter commented Oct 22, 2024

Thanks for the submission. Will make the next release.

Actually license rules are something I want to revisit at some point, based on the logic used in https://github.com/boyter/lc but turning those rules into something that works using JSON.

@spenserblack spenserblack deleted the license-apache branch October 22, 2024 22:48
@spenserblack
Copy link
Contributor Author

Interesting! I'm sure you've already thought about this, but in another project I've worked on there were issues detecting if the license was "GPL X.Y Only" or "GPL X.Y or Later" (o2sh/onefetch#1251). Just a heads up for when you're planning implementation.

@boyter
Copy link
Owner

boyter commented Oct 22, 2024

For scc its only attempting to identify there is a license file, not the contents of it. Finding the version is a whole other issue I need to get back to working on again one of these days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: DONE
Development

Successfully merging this pull request may close these issues.

2 participants