Skip to content

Commit

Permalink
fix broken mobile scroll view navigation where there were fragments s…
Browse files Browse the repository at this point in the history
…tarting at an index above 1 hakimel#3540
  • Loading branch information
hakimel committed Nov 30, 2023
1 parent bf285af commit d5896c9
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 14 deletions.
2 changes: 1 addition & 1 deletion dist/reveal.esm.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/reveal.esm.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/reveal.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/reveal.js.map

Large diffs are not rendered by default.

20 changes: 10 additions & 10 deletions js/controllers/scrollview.js
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,6 @@ export default class ScrollView {
];

const scrollTriggerSegmentSize = ( trigger.range[1] - trigger.range[0] ) / trigger.page.scrollTriggers.length;

// Set the range for each inner scroll trigger
trigger.page.scrollTriggers.forEach( ( scrollTrigger, i ) => {
scrollTrigger.range = [
Expand Down Expand Up @@ -462,16 +461,17 @@ export default class ScrollView {
activate: () => {
this.Reveal.fragments.update( -1, page.fragments, slideElement );
}
},

// Triggers for each fragment group
...fragmentGroups.map( ( fragments, i ) => ({
activate: () => {
this.Reveal.fragments.update( i, page.fragments, slideElement );
}
})
)
}
);

// Triggers for each fragment group
fragmentGroups.forEach( ( fragments, i ) => {
page.scrollTriggers.push({
activate: () => {
this.Reveal.fragments.update( i, page.fragments, slideElement );
}
});
} );
}


Expand Down

0 comments on commit d5896c9

Please sign in to comment.