Skip to content

Commit

Permalink
Fix rake not including the rubocop task
Browse files Browse the repository at this point in the history
Honestly, I don't know if I want to even bother with rubocop in the legacy
codebase. The styling is being closely monitored in the rework, and code style
isn't really critical when it comes to security patches and bug fixes.

All to say, I may just disable the rubocop job for the legacy code again at some
point, if it gets annoying.
  • Loading branch information
joshbuker committed Apr 4, 2021
1 parent a26ed98 commit 5d95834
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 2 deletions.
10 changes: 9 additions & 1 deletion .rubocop_todo.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2021-01-02 07:53:19 UTC using RuboCop version 0.88.0.
# on 2021-04-04 05:00:11 UTC using RuboCop version 0.88.0.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
Expand Down Expand Up @@ -147,6 +147,14 @@ Style/StringLiterals:
- 'spec/controllers/controller_oauth2_spec.rb'
- 'spec/sorcery_crypto_providers_spec.rb'

# Offense count: 1
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, MinSize.
# SupportedStyles: percent, brackets
Style/SymbolArray:
Exclude:
- 'Rakefile'

# Offense count: 2
# Cop supports --auto-correct.
Style/UnpackFirst:
Expand Down
4 changes: 3 additions & 1 deletion Rakefile
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
require 'bundler/gem_tasks'

require 'rspec/core/rake_task'
require 'rubocop/rake_task'
RSpec::Core::RakeTask.new(:spec)
RuboCop::RakeTask.new

task default: :spec
task default: [:rubocop, :spec]

0 comments on commit 5d95834

Please sign in to comment.