Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BoxView: Fix Tests and Update GraphQL Error Policy for BoxView Query #830

Merged
merged 2 commits into from
Jun 30, 2023

Conversation

vahidbazzaz
Copy link
Contributor

  • fix boxview tests - add cache
  • add support for partial response to boxview

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #830 (97a8eeb) into master (bfcebc4) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #830   +/-   ##
=======================================
  Coverage   70.44%   70.44%           
=======================================
  Files         269      269           
  Lines        6554     6554           
  Branches     1298     1298           
=======================================
  Hits         4617     4617           
  Misses       1903     1903           
  Partials       34       34           
Flag Coverage Δ
backend 96.74% <ø> (ø)
frontend 47.62% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
react/src/views/Box/BoxView.tsx 60.97% <100.00%> (ø)

@vahidbazzaz vahidbazzaz marked this pull request as ready for review June 30, 2023 11:39
@vahidbazzaz vahidbazzaz changed the title BoxView & BoxEdit: Fix Tests and Update GraphQl Error Policy for BoxView Query BoxView: Fix Tests and Update GraphQl Error Policy for BoxView Query Jun 30, 2023
@vahidbazzaz vahidbazzaz changed the title BoxView: Fix Tests and Update GraphQl Error Policy for BoxView Query BoxView: Fix Tests and Update GraphQL Error Policy for BoxView Query Jun 30, 2023
@pylipp pylipp merged commit 35f4280 into master Jun 30, 2023
5 checks passed
@pylipp pylipp deleted the bugfix/boxview-boxedit-tests branch June 30, 2023 13:29
@pylipp
Copy link
Contributor

pylipp commented Jun 30, 2023

Thanks for the fixes 🙌 @vahidbazzaz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants