Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop logging expected GraphQL errors in test output #1535

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

jamescrowley
Copy link
Contributor

The current test set up intercepts GraphQL errors to print them as output. This is useful, as they warn about missing mock data and other errors. However, these messages are mixed up in 'expected' failures that we've set up in the tests themselves.

This PR switches to separate classes for our fake errors so we can exclude them from the console output.

@jamescrowley jamescrowley changed the title Stop logging mocked GraphQL errors in test output Stop logging expected GraphQL errors in test output Sep 13, 2024
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.85%. Comparing base (52e1022) to head (9b1046a).
Report is 83 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1535   +/-   ##
=======================================
  Coverage   85.85%   85.85%           
=======================================
  Files         229      229           
  Lines       21709    21709           
  Branches     1927     1927           
=======================================
  Hits        18639    18639           
  Misses       3034     3034           
  Partials       36       36           
Flag Coverage Δ
backend 99.07% <ø> (ø)
frontend 82.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamescrowley jamescrowley force-pushed the ignore-expected-graphql-errors-in-tests branch from 6b7c908 to e689cbf Compare September 13, 2024 08:51
@jamescrowley jamescrowley force-pushed the ignore-expected-graphql-errors-in-tests branch from e689cbf to 9b1046a Compare September 13, 2024 08:53
@jamescrowley jamescrowley marked this pull request as ready for review September 13, 2024 09:04
@jamescrowley
Copy link
Contributor Author

@jamescrowley jamescrowley merged commit 67e738f into master Oct 9, 2024
11 checks passed
@jamescrowley jamescrowley deleted the ignore-expected-graphql-errors-in-tests branch October 9, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant