Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Tags history #1472

Merged
merged 24 commits into from
Sep 19, 2024
Merged

Feature: Tags history #1472

merged 24 commits into from
Sep 19, 2024

Conversation

pylipp
Copy link
Contributor

@pylipp pylipp commented Aug 14, 2024

  • Add temporal columns to TagsRelation
  • Update TagsRelation business logic to set temporal fields when assigning or removing tags
  • Update DB seed

@pylipp pylipp force-pushed the add-temporal-columns-to-tags-relation branch 5 times, most recently from 9377ec7 to 44745e9 Compare August 19, 2024 14:35
@pylipp
Copy link
Contributor Author

pylipp commented Aug 19, 2024

@pylipp pylipp force-pushed the add-temporal-columns-to-tags-relation branch from 44745e9 to 33f6ce6 Compare August 20, 2024 10:23
@pylipp pylipp changed the title add temporal columns to tags relation Add temporal columns to TagsRelation Aug 26, 2024
Copy link
Member

@HaGuesto HaGuesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code reviewed passed

feature review

We move the feature review to when INserts and Deletions are also covered, because we need an updated init.sql here first.

@pylipp pylipp force-pushed the add-temporal-columns-to-tags-relation branch from 33f6ce6 to 3ceaf81 Compare August 28, 2024 11:52
@pylipp pylipp force-pushed the add-temporal-columns-to-tags-relation branch from 3ceaf81 to a8836d9 Compare September 2, 2024 08:56
@HaGuesto HaGuesto marked this pull request as ready for review September 12, 2024 12:29
@pylipp pylipp changed the title Add temporal columns to TagsRelation Feature: Tags history Sep 17, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.59%. Comparing base (0317b05) to head (14f14ab).
Report is 73 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1472   +/-   ##
=======================================
  Coverage   85.59%   85.59%           
=======================================
  Files         232      232           
  Lines       21710    21727   +17     
  Branches     1916     1920    +4     
=======================================
+ Hits        18582    18597   +15     
- Misses       3088     3090    +2     
  Partials       40       40           
Flag Coverage Δ
backend 99.02% <ø> (-0.05%) ⬇️
frontend 82.35% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HaGuesto
Copy link
Member

HaGuesto commented Sep 17, 2024

functional review

@pylipp
There is only one case where I'd probably change something. I would not show Box history items about assigning tags on the timestamp when the box is created. We also do not show the selected product at the moment of creation in the box history and this would end up confusing when tags are assigned before the box is created.
image

Therefore, I'd remove the assign tags entries from the box history when the box is created.

@pylipp
Copy link
Contributor Author

pylipp commented Sep 17, 2024

I agree that it might be confusing to see the created-record entries as more recent in the history. I thought this might be solved by grouping history entries with identical timestamp (tagged you in trello).

If you think this is not sufficient, I'll try to make the assigned-tag entries that belong to creation disappear. I think the easiest way is to not set the created-fields of TagsRelations when creating a box. Then these fields would only be set if an existing box is updated with tags.

@HaGuesto HaGuesto merged commit 0206306 into master Sep 19, 2024
8 of 9 checks passed
@HaGuesto HaGuesto deleted the add-temporal-columns-to-tags-relation branch September 19, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants