-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Tags history #1472
Feature: Tags history #1472
Conversation
pylipp
commented
Aug 14, 2024
•
edited
Loading
edited
- Add temporal columns to TagsRelation
- Update TagsRelation business logic to set temporal fields when assigning or removing tags
- Update DB seed
9377ec7
to
44745e9
Compare
44745e9
to
33f6ce6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code reviewed passed
feature review
We move the feature review to when INserts and Deletions are also covered, because we need an updated init.sql here first.
33f6ce6
to
3ceaf81
Compare
3ceaf81
to
a8836d9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1472 +/- ##
=======================================
Coverage 85.59% 85.59%
=======================================
Files 232 232
Lines 21710 21727 +17
Branches 1916 1920 +4
=======================================
+ Hits 18582 18597 +15
- Misses 3088 3090 +2
Partials 40 40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
back/boxtribute_server/graph_ql/definitions/protected/types.graphql
Outdated
Show resolved
Hide resolved
functional review@pylipp Therefore, I'd remove the assign tags entries from the box history when the box is created. |
I agree that it might be confusing to see the created-record entries as more recent in the history. I thought this might be solved by grouping history entries with identical timestamp (tagged you in trello). If you think this is not sufficient, I'll try to make the assigned-tag entries that belong to creation disappear. I think the easiest way is to not set the created-fields of TagsRelations when creating a box. Then these fields would only be set if an existing box is updated with tags. |