-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/permissions for statviz dashboard #1412
Conversation
@jlin95 Thank you very much for your first review! 🥳 |
…ix/permissions_for_statviz_dashboard
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1412 +/- ##
==========================================
- Coverage 84.81% 84.80% -0.02%
==========================================
Files 240 241 +1
Lines 15452 15463 +11
Branches 1651 1631 -20
==========================================
+ Hits 13106 13113 +7
- Misses 2307 2311 +4
Partials 39 39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
[Not a blocking comment] Would it be good to introduce tests for the useAuthorization hook? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @HaGuesto, though I left a small comment on writing a test for the hook.
@jlin95 you are right. I should write a test for this since it is quite an integral part. |
After you merged, I'll check on staging that the roles HoO, coordinator, warehouse vol, freeshop vol can view the statviz page but roles library volunteer, label creator, external checkout can't. |
thanks for taking this up so quickly @fhenrich33 😃 |
No description provided.