Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/permissions for statviz dashboard #1412

Merged
merged 13 commits into from
Nov 13, 2024

Conversation

HaGuesto
Copy link
Member

No description provided.

front/src/hooks/useAuthorization.ts Outdated Show resolved Hide resolved
front/src/hooks/useAuthorization.ts Outdated Show resolved Hide resolved
@HaGuesto
Copy link
Member Author

@jlin95 Thank you very much for your first review! 🥳
I added created some constants.

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.80%. Comparing base (8441871) to head (9ddb1be).
Report is 18 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1412      +/-   ##
==========================================
- Coverage   84.81%   84.80%   -0.02%     
==========================================
  Files         240      241       +1     
  Lines       15452    15463      +11     
  Branches     1651     1631      -20     
==========================================
+ Hits        13106    13113       +7     
- Misses       2307     2311       +4     
  Partials       39       39              
Flag Coverage Δ
backend 99.12% <ø> (ø)
frontend 78.57% <ø> (-0.02%) ⬇️
sharedComponents 78.99% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jlin95
Copy link
Contributor

jlin95 commented Jul 26, 2024

[Not a blocking comment] Would it be good to introduce tests for the useAuthorization hook?

@jlin95 jlin95 self-requested a review July 26, 2024 07:06
Copy link
Contributor

@jlin95 jlin95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @HaGuesto, though I left a small comment on writing a test for the hook.

@HaGuesto
Copy link
Member Author

@jlin95 you are right. I should write a test for this since it is quite an integral part.

@pylipp
Copy link
Contributor

pylipp commented Oct 17, 2024

After you merged, I'll check on staging that the roles HoO, coordinator, warehouse vol, freeshop vol can view the statviz page but roles library volunteer, label creator, external checkout can't.

front/src/App.tsx Outdated Show resolved Hide resolved
@pylipp
Copy link
Contributor

pylipp commented Nov 13, 2024

thanks for taking this up so quickly @fhenrich33 😃

@fhenrich33 fhenrich33 merged commit ceef9b7 into master Nov 13, 2024
11 checks passed
@fhenrich33 fhenrich33 deleted the fix/permissions_for_statviz_dashboard branch November 13, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants