Enable DB replica #1104
Enable DB replica #1104
Conversation
pylipp
force-pushed
the
statviz-enable-db-replica
branch
2 times, most recently
from
99ebf44
to
bcf41d9
Compare
Codecov Report
@@ Coverage Diff @@
## master #1104 +/- ##
==========================================
- Coverage 73.02% 72.94% -0.08%
==========================================
Files 290 290
Lines 7439 7499 +60
Branches 1567 1580 +13
==========================================
+ Hits 5432 5470 +38
- Misses 1963 1985 +22
Partials 44 44
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pylipp
force-pushed
the
statviz-enable-db-replica
branch
3 times, most recently
from
5e30cfa
to
10a84fa
Compare
The deployed env does not need host nor port since it uses a socket connection
Affects (integration) testing only, and simplifies local development
pylipp
force-pushed
the
statviz-enable-db-replica
branch
from
10a84fa
to
72fabb2
Compare
pylipp
added this to the B. BE Historical data architecture implemented & ADR milestone
|
@HaGuesto priority |
There was a problem hiding this comment.
I like your solution, feels elegant. @pylipp
Just one comment: we started actually that we do not want the statviz queries to have an effect or block behavior in Boxtribute. Since now the replica is used for ALL querys, we just ensured that the statviz queries will not have an effect on the mutations in Boxtribute.
However, we also started at the point that we want to make these queries public and that is not happening at least for now. Therefore, I'm fine with this PR and it will be a nice test.
| @@ -193,7 +193,8 @@ jobs: | |||
| name: Run pytest | |||
| command: | | |||
| source $(pyenv root)/versions/3.10.4/envs/env/bin/activate | |||
| ENVIRONMENT=test pytest --cov-report xml:test-results/coverage.xml --cov=boxtribute_server | |||
| # overwrite environment variable because it must not depend on the CircleCI context | |||
| ENVIRONMENT=development MYSQL_PORT=3306 pytest --cov-report xml:test-results/coverage.xml --cov=boxtribute_server | |||
There was a problem hiding this comment.
weird that the socket is needed here if you are using a socket
There was a problem hiding this comment.
What do you mean? weird that the port is needed? It's because the connection to the DB for integration tests is via TCP. Socket will only be effective in deployed environments.
| unix_socket=os.getenv("MYSQL_SOCKET"), | ||
| replica_socket=os.getenv("MYSQL_REPLICA_SOCKET"), |
There was a problem hiding this comment.
We need to remember to set this variable in the contexts in circleci
There was a problem hiding this comment.
I already set it as a project-wide variable
|
|
||
| class BaseModel(self.base_model_class): | ||
| @classmethod | ||
| def select(cls, *args, **kwargs): |
|
@pylipp we are tracking the latency of the server, right? We should have an alert or track it in order to compare before and after. Would love to see the difference. |
I implemented a custom class derived from peewee's
FlaskDBto glue together Flask and the databases (the primary one and, for select-queries, the replica).Further changes are about cleaning up env variables related to configure the DB connection locally and in CircleCI.