BoxesView: Implement Loading/Error Handling #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vahidbazzaz
commented
Nov 3, 2023
vahidbazzaz
commented
- implement error handling
- add test case 4.8.1
Codecov Report
@@ Coverage Diff @@
## master #1094 +/- ##
==========================================
+ Coverage 71.75% 73.05% +1.29%
==========================================
Files 289 289
Lines 7428 7429 +1
Branches 1560 1561 +1
==========================================
+ Hits 5330 5427 +97
+ Misses 2057 1960 -97
- Partials 41 42 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
HaGuesto
reviewed
Nov 3, 2023
| // Test case 4.8.1.3 | ||
| const row = await screen.findByRole("row", { | ||
| // eslint-disable-next-line max-len | ||
| name: /toggle all rows selected toggle sortby toggle sortby toggle sortby toggle sortby toggle sortby toggle sortby toggle sortby toggle sortby/i, |
There was a problem hiding this comment.
@HaGuesto I will change it later, but I got this quick selector using the testing library chrome plugin :)
HaGuesto
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.