Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename RBP to 'product_category' #1091

Merged
merged 1 commit into from
Nov 4, 2023
Merged

Conversation

pylipp
Copy link
Contributor

@pylipp pylipp commented Nov 2, 2023

More precise naming matching the model name (ProductCategory)

  • ✔️ Auth0 actions updated for dev, staging, and production tenants
  • ✔️ RBP google sheet updated

More precise naming matching the model name (ProductCategory)
@pylipp
Copy link
Contributor Author

pylipp commented Nov 2, 2023

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #1091 (54a3a58) into master (cdd2d5d) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1091      +/-   ##
==========================================
- Coverage   71.73%   71.72%   -0.01%     
==========================================
  Files         290      290              
  Lines        7440     7438       -2     
  Branches     1567     1566       -1     
==========================================
- Hits         5337     5335       -2     
  Misses       2060     2060              
  Partials       43       43              
Flag Coverage Δ
backend 96.94% <100.00%> (-0.01%) ⬇️
frontend 51.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
back/boxtribute_server/authz.py 97.36% <ø> (ø)
...er/business_logic/core/product_category/queries.py 100.00% <100.00%> (ø)
back/boxtribute_server/graph_ql/loaders.py 100.00% <ø> (ø)

@pylipp pylipp merged commit 6d479ad into master Nov 4, 2023
13 checks passed
@pylipp pylipp deleted the rename-product-category-rbp branch November 4, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants