Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Programming task for moved-boxes problem #1080

Closed
wants to merge 5 commits into from

Conversation

pylipp
Copy link
Contributor

@pylipp pylipp commented Oct 24, 2023

[skip ci]
@pylipp pylipp force-pushed the statviz/moved-boxes-programming-task branch from 9d6c6bb to e76d09e Compare October 24, 2023 09:23
@pylipp pylipp added this to the 4th viz milestone Oct 24, 2023
@pylipp pylipp linked an issue Oct 24, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #1080 (a39d2e5) into master (099abca) will decrease coverage by 24.01%.
Report is 59 commits behind head on master.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #1080       +/-   ##
===========================================
- Coverage   96.98%   72.97%   -24.01%     
===========================================
  Files         107      285      +178     
  Lines        3312     7426     +4114     
  Branches      316     1567     +1251     
===========================================
+ Hits         3212     5419     +2207     
- Misses         82     1965     +1883     
- Partials       18       42       +24     
Flag Coverage Δ
backend 96.98% <ø> (ø)
frontend 53.64% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 178 files with indirect coverage changes

@pylipp pylipp marked this pull request as draft October 24, 2023 09:51
@pylipp pylipp requested a review from HaGuesto October 24, 2023 13:20
@HaGuesto
Copy link
Member

Generally, I would also recommend that you add a larger Sql dump file with the example data to the PR, too.

docs/moved-boxes-task.md Outdated Show resolved Hide resolved
docs/moved-boxes-task.md Outdated Show resolved Hide resolved
docs/moved-boxes-task.md Outdated Show resolved Hide resolved
docs/moved-boxes-task.md Outdated Show resolved Hide resolved
docs/moved-boxes-task.md Show resolved Hide resolved
docs/moved-boxes-task.md Outdated Show resolved Hide resolved
docs/moved-boxes-task.md Outdated Show resolved Hide resolved
docs/moved-boxes-task.md Outdated Show resolved Hide resolved
docs/moved-boxes-task.md Outdated Show resolved Hide resolved
docs/moved-boxes-task.md Outdated Show resolved Hide resolved
@pylipp pylipp force-pushed the statviz/moved-boxes-programming-task branch from 4ced1c1 to 34ed0de Compare October 27, 2023 15:44
Added higher level business objective and image

Signed-off-by: Roanna K <[email protected]>
@HaGuesto
Copy link
Member

@pylipp we should also probably close this, right?

@pylipp
Copy link
Contributor Author

pylipp commented Jan 23, 2024

@HaGuesto yep, it's not relevant anymore.
Maybe we come back to it for a similar problem in the future. The problem here is solved by #1190 .

@pylipp pylipp closed this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Merged to staging
Development

Successfully merging this pull request may close these issues.

[B] 4th viz: BE optimize query by e.g. caching
3 participants