-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Programming task for moved-boxes problem #1080
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[skip ci]
pylipp
force-pushed
the
statviz/moved-boxes-programming-task
branch
from
October 24, 2023 09:23
9d6c6bb
to
e76d09e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1080 +/- ##
===========================================
- Coverage 96.98% 72.97% -24.01%
===========================================
Files 107 285 +178
Lines 3312 7426 +4114
Branches 316 1567 +1251
===========================================
+ Hits 3212 5419 +2207
- Misses 82 1965 +1883
- Partials 18 42 +24
Flags with carried forward coverage won't be shown. Click here to find out more. |
Generally, I would also recommend that you add a larger Sql dump file with the example data to the PR, too. |
HaGuesto
reviewed
Oct 26, 2023
HaGuesto
reviewed
Oct 26, 2023
HaGuesto
reviewed
Oct 26, 2023
pylipp
commented
Oct 26, 2023
pylipp
force-pushed
the
statviz/moved-boxes-programming-task
branch
from
October 27, 2023 15:44
4ced1c1
to
34ed0de
Compare
Added higher level business objective and image Signed-off-by: Roanna K <[email protected]>
@pylipp we should also probably close this, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered version:
https://github.com/boxwise/boxtribute/blob/statviz/moved-boxes-programming-task/docs/moved-boxes-task.md