Use typehints instead of comments and remove redundant object #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As for the tests, you'd have to describe the problem you had.... afaik they should be good. They certainly run here on github. |
I figured it out, I am running python 3.11 and the issue is essentially this one: #266. It is fixed by installing pony from github. |
EJahren
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@boxed we spoke earlier on discord. I just wanted to try a simple PR just to see what the house rules are like in your repository. Hopefully I haven't stepped on any feet :)
Now, I can't get most of the tests to work locally. Is there something wrong with my setup, or is it a known issue?