Update Namesilo.php #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I removed throwing exception when someone is not using Payment ID, this prevented them for using module without Payment ID defined. But there is an issue, this is how input box is showing. <input id="el-Payment_ID" type="Payment_ID" name="config[Payment_ID]" value="" required="required"> It is set to REQUIRED and I have no idea how do i change that... I'm going to contact boxbilling musicboxlimited for this and i'm gonna do another pull request. So basically, once you define Payment ID only way to remove it is to inspect element and remove required="required" and then save it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed throwing exception when someone is not using Payment ID, this prevented them from using module without Payment ID defined.
But there is an issue, this is how input box is showing.
<input id="el-Payment_ID" type="Payment_ID" name="config[Payment_ID]" value="" required="required">It is set to REQUIRED and I have no idea how do i change that... I'm going to contact boxbilling musicboxlimited for this and i'm gonna do another pull request.
So basically, once you define Payment ID only way to remove it is to inspect element and remove
required="required"and then save it.