fix: add handling to update_user_by_id to allow setting enterprise to 'null' to roll users off enterprise #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Djones4822
changed the title
|
Hi @Djones4822 However, we cannot merge this PR because the code in this repository is generated by our product codegen based on the API. Even if we merged this or any other PR modifying the code, these changes would be overwritten the next time the generator is run. To address the issue correctly, we need to make changes to our code generator to support nullable fields globally. Nevertheless, we appreciate the inspiration, it will certainly be useful 👍 Regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added handling to the
update_user_by_idto allow the string"null"forenterpriseto properly clear the enterprise as per the api documentation. I'm unsure where else this pattern may exist, but it seems that the sdk generally does not allow users to "clear" values since theserializemethod always filters out values set to None. This PR only addresses this one use case through direct handling of theenterpriserequest body parameter.