Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Sign request group #870

Merged
merged 11 commits into from
Jan 9, 2024
Merged

feat: Sign request group #870

merged 11 commits into from
Jan 9, 2024

Conversation

congminh1254
Copy link
Member

No description provided.

@coveralls
Copy link
Collaborator

coveralls commented Dec 29, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7421956422

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 95.503%
Totals Coverage Status
Change from base Build 7346873648: -0.1%
Covered Lines: 2955
Relevant Lines: 3064
💛 - Coveralls

lukaszsocha2
lukaszsocha2 requested changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@lukaszsocha2 lukaszsocha2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls add integration test for this. You can use same scenario as in Java SDK

@congminh1254 congminh1254 merged commit 11bf5d2 into main Jan 9, 2024
11 checks passed
@congminh1254 congminh1254 deleted the sign-request-group branch January 9, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszsocha2 lukaszsocha2 lukaszsocha2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@congminh1254 @coveralls @lukaszsocha2