Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add request option to skip PassThrough #863

Merged
merged 3 commits into from
Nov 3, 2023

Conversation

rlyonbox
Copy link
Contributor

@rlyonbox rlyonbox commented Nov 2, 2023

The PassThrough is causing us a few issues, and I can't figure out why it was added - this PR adds an option which avoids the usage of it optionally while leaving the default behavior as PassThrough.

@CLAassistant
Copy link

CLAassistant commented Nov 2, 2023

CLA assistant check
All committers have signed the CLA.

@rlyonbox rlyonbox changed the title feat: Add disableStreamPassthrough request options feat: Add request option to skip PassThrough Nov 2, 2023
@rlyonbox rlyonbox changed the title feat: Add request option to skip PassThrough feat: Add request option to skip PassThrough Nov 2, 2023
@coveralls
Copy link
Collaborator

coveralls commented Nov 2, 2023

Pull Request Test Coverage Report for Build 6744067792

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 95.672%

Totals Coverage Status
Change from base Build 6653679495: 0.003%
Covered Lines: 2956
Relevant Lines: 3058

💛 - Coveralls

Copy link
Member

@congminh1254 congminh1254 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@congminh1254 congminh1254 merged commit 726db45 into box:main Nov 3, 2023
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants