Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support login_required, password, suppress_nofitications, verification_phone_number and additional_info fields in sign request #1250

Merged
merged 4 commits into from
Jun 6, 2024
Merged

feat: Support login_required, password, suppress_nofitications, verification_phone_number and additional_info fields in sign request #1250

merged 4 commits into from
Jun 6, 2024

Conversation

congminh1254
Copy link
Member

@congminh1254 congminh1254 commented Jun 4, 2024 •
edited
Loading

Closes: SDK-3826

@coveralls
Copy link

coveralls commented Jun 4, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build #3828

Details

  • 31 of 32 (96.88%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 72.149%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/BoxSignRequestSigner.java 23 24 95.83%
Totals Coverage Status
Change from base Build #3817: 0.1%
Covered Lines: 7642
Relevant Lines: 10592
💛 - Coveralls

@congminh1254 congminh1254 changed the title feat: Support login_required, password, suppress_nofitications and verification_phone_number fields in sign request feat: Support login_required, password, suppress_nofitications, verification_phone_number and additional_info fields in sign request Jun 5, 2024
@arjankowski
Copy link
Contributor

@congminh1254 shouldn't we also add here a new webhooks in BoxWebHook.java file?

* SIGN.REQUEST.SIGNATURE_REQUESTED
* SIGN.REQUEST.SIGNER_SIGNED
* SIGN.REQUEST.ERROR_FINALIZING

arjankowski
arjankowski approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@arjankowski arjankowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@arjankowski arjankowski merged commit 3ee55b3 into main Jun 6, 2024
11 of 12 checks passed
@arjankowski arjankowski deleted the sign-suppress-notification branch June 6, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjankowski arjankowski arjankowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@congminh1254 @coveralls @arjankowski