Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add signer_group_id for signer in sign request #1220

Merged
merged 5 commits into from
Dec 21, 2023
Merged

feat: Add signer_group_id for signer in sign request #1220

merged 5 commits into from
Dec 21, 2023

Conversation

lukaszsocha2
Copy link
Contributor

Closes: SDK-3518

@coveralls
Copy link

coveralls commented Dec 21, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build #3445

  • 1 of 13 (7.69%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.07%) to 71.466%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/BoxSignRequestSigner.java 1 6 16.67%
src/main/java/com/box/sdk/BoxSignTemplateSigner.java 0 7 0.0%
Files with Coverage Reduction New Missed Lines %
src/main/java/com/box/sdk/BoxSignTemplateSigner.java 1 51.83%
Totals Coverage Status
Change from base Build #3410: -0.07%
Covered Lines: 7436
Relevant Lines: 10405
💛 - Coveralls

@lukaszsocha2 lukaszsocha2 merged commit f560db8 into main Dec 21, 2023
10 checks passed
@lukaszsocha2 lukaszsocha2 deleted the sdk-3518-support-group-field-for-sign-api branch December 21, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhagmajer mhagmajer mhagmajer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukaszsocha2 @coveralls @mhagmajer