Skip to content

Commit

Permalink
fix: improve wording for box sign (box/box-openapi#424)
Browse files Browse the repository at this point in the history
  • Loading branch information
box-sdk-build committed May 16, 2024
1 parent f9d5bcb commit 69187fe
Show file tree
Hide file tree
Showing 12 changed files with 49 additions and 48 deletions.
2 changes: 1 addition & 1 deletion .codegen.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "engineHash": "3eadef2", "specHash": "98bca8f", "version": "0.3.1" }
{ "engineHash": "3eadef2", "specHash": "f26f46d", "version": "0.3.1" }
16 changes: 8 additions & 8 deletions Box.Sdk.Gen/Managers/SignRequests/SignRequestsManager.cs
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public SignRequestsManager(NetworkSession networkSession = default) {
/// Cancels a sign request.
/// </summary>
/// <param name="signRequestId">
/// The ID of the sign request
/// The ID of the signature request
/// Example: "33243242"
/// </param>
/// <param name="headers">
Expand All @@ -38,10 +38,10 @@ public async System.Threading.Tasks.Task<SignRequest> CancelSignRequestAsync(str
}

/// <summary>
/// Resends a sign request email to all outstanding signers.
/// Resends a signature request email to all outstanding signers.
/// </summary>
/// <param name="signRequestId">
/// The ID of the sign request
/// The ID of the signature request
/// Example: "33243242"
/// </param>
/// <param name="headers">
Expand All @@ -60,7 +60,7 @@ public async System.Threading.Tasks.Task ResendSignRequestAsync(string signReque
/// Gets a sign request by ID.
/// </summary>
/// <param name="signRequestId">
/// The ID of the sign request
/// The ID of the signature request
/// Example: "33243242"
/// </param>
/// <param name="headers">
Expand All @@ -77,8 +77,8 @@ public async System.Threading.Tasks.Task<SignRequest> GetSignRequestByIdAsync(st
}

/// <summary>
/// Gets sign requests created by a user. If the `sign_files` and/or
/// `parent_folder` are deleted, the sign request will not return in the list.
/// Gets signature requests created by a user. If the `sign_files` and/or
/// `parent_folder` are deleted, the signature request will not return in the list.
/// </summary>
/// <param name="queryParams">
/// Query parameters of getSignRequests method
Expand All @@ -99,8 +99,8 @@ public async System.Threading.Tasks.Task<SignRequests> GetSignRequestsAsync(GetS
}

/// <summary>
/// Creates a sign request. This involves preparing a document for signing and
/// sending the sign request to signers.
/// Creates a signature request. This involves preparing a document for signing and
/// sending the signature request to signers.
/// </summary>
/// <param name="requestBody">
/// Request body of createSignRequest method
Expand Down
11 changes: 6 additions & 5 deletions Box.Sdk.Gen/Schemas/SignRequest/SignRequest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public class SignRequest : SignRequestBase {
public IReadOnlyList<FileBase>? SourceFiles { get; set; } = default;

/// <summary>
/// Array of signers for the sign request
/// Array of signers for the signature request.
/// </summary>
[JsonPropertyName("signers")]
public IReadOnlyList<SignRequestSigner>? Signers { get; set; } = default;
Expand All @@ -32,15 +32,16 @@ public class SignRequest : SignRequestBase {
public string? SignatureColor { get; set; } = default;

/// <summary>
/// Sign request ID
/// Box Sign request ID.
/// </summary>
[JsonPropertyName("id")]
public string? Id { get; set; } = default;

/// <summary>
/// This URL is returned if `is_document_preparation_needed` is
/// set to `true` in the request. It is used to prepare the sign request
/// via UI. The sign request is not sent until preparation is complete.
/// set to `true` for Box Sign request. It is used to prepare a signature request
/// using the UI. The signature request is not sent until the preparation
/// phase is complete.
/// </summary>
[JsonPropertyName("prepare_url")]
public string? PrepareUrl { get; set; } = default;
Expand All @@ -49,7 +50,7 @@ public class SignRequest : SignRequestBase {
public FileMini? SigningLog { get; set; } = default;

/// <summary>
/// Describes the status of the sign request
/// Describes the status of the signature request.
/// </summary>
[JsonPropertyName("status")]
public SignRequestStatusField? Status { get; set; } = default;
Expand Down
8 changes: 4 additions & 4 deletions Box.Sdk.Gen/Schemas/SignRequestBase/SignRequestBase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@
namespace Box.Sdk.Gen.Schemas {
public class SignRequestBase {
/// <summary>
/// Indicates if the sender should receive a `prepare_url` in the response to complete document preparation via UI.
/// Indicates if the sender should receive a `prepare_url` in the response to complete document preparation using the UI.
/// </summary>
[JsonPropertyName("is_document_preparation_needed")]
public bool? IsDocumentPreparationNeeded { get; set; } = default;

/// <summary>
/// When specified, signature request will be redirected to this url when a document is signed.
/// When specified, the signature request will be redirected to this url when a document is signed.
/// </summary>
[JsonPropertyName("redirect_url")]
public string? RedirectUrl { get; set; } = default;
Expand Down Expand Up @@ -50,13 +50,13 @@ public class SignRequestBase {
public bool? AreRemindersEnabled { get; set; } = default;

/// <summary>
/// Name of the sign request.
/// Name of the signature request.
/// </summary>
[JsonPropertyName("name")]
public string? Name { get; set; } = default;

/// <summary>
/// When a document contains sign related tags in the content, you can prefill them using this `prefill_tags` by referencing the 'id' of the tag as the `external_id` field of the prefill tag.
/// When a document contains sign-related tags in the content, you can prefill them using this `prefill_tags` by referencing the 'id' of the tag as the `external_id` field of the prefill tag.
/// </summary>
[JsonPropertyName("prefill_tags")]
public IReadOnlyList<SignRequestPrefillTag>? PrefillTags { get; set; } = default;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public class SignRequestCreateRequest : SignRequestBase {
public SignRequestCreateRequestSignatureColorField? SignatureColor { get; set; } = default;

/// <summary>
/// Array of signers for the sign request. 35 is the max number of signers permitted.
/// Array of signers for the signature request. 35 is the max number of signers permitted.
/// </summary>
[JsonPropertyName("signers")]
public IReadOnlyList<SignRequestCreateSigner> Signers { get; set; }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public class SignRequestCreateSigner {
public string? Email { get; set; } = default;

/// <summary>
/// Defines the role of the signer in the sign request. A `signer`
/// Defines the role of the signer in the signature request. A `signer`
/// must sign the document and an `approver` must approve the document. A
/// `final_copy_reader` only receives the final signed document and signing
/// log.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
namespace Box.Sdk.Gen.Schemas {
public class SignRequestPrefillTag {
/// <summary>
/// This references the ID of a specific tag contained in a file of the sign request.
/// This references the ID of a specific tag contained in a file of the signature request.
/// </summary>
[JsonPropertyName("document_tag_id")]
public string? DocumentTagId { get; set; } = default;
Expand Down
4 changes: 2 additions & 2 deletions Box.Sdk.Gen/Schemas/SignRequestSigner/SignRequestSigner.cs
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public class SignRequestSigner : SignRequestCreateSigner {
public bool? HasViewedDocument { get; set; } = default;

/// <summary>
/// Final decision made by the signer
/// Final decision made by the signer.
/// </summary>
[JsonPropertyName("signer_decision")]
public SignRequestSignerSignerDecisionField? SignerDecision { get; set; } = default;
Expand All @@ -34,7 +34,7 @@ public class SignRequestSigner : SignRequestCreateSigner {
/// It will be returned in the response
/// only if the `embed_url_external_user_id`
/// parameter was passed in the
/// `create sign request` call.
/// `create Box Sign request` call.
/// </summary>
[JsonPropertyName("iframeable_embed_url")]
public string? IframeableEmbedUrl { get; set; } = default;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,19 @@
namespace Box.Sdk.Gen.Schemas {
public class SignRequestSignerSignerDecisionField {
/// <summary>
/// Type of decision made by the signer
/// Type of decision made by the signer.
/// </summary>
[JsonPropertyName("type")]
public SignRequestSignerSignerDecisionTypeField? Type { get; set; } = default;

/// <summary>
/// Date and Time that the decision was made
/// Date and Time that the decision was made.
/// </summary>
[JsonPropertyName("finalized_at")]
public System.DateTimeOffset? FinalizedAt { get; set; } = default;

/// <summary>
/// Additional info about the decision, such as the decline reason from the signer
/// Additional info about the decision, such as the decline reason from the signer.
/// </summary>
[JsonPropertyName("additional_info")]
public string? AdditionalInfo { get; set; } = default;
Expand Down
2 changes: 1 addition & 1 deletion Box.Sdk.Gen/Schemas/SignRequests/SignRequests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public class SignRequests {
public string? NextMarker { get; set; } = default;

/// <summary>
/// A list of sign requests
/// A list of Box Sign requests.
/// </summary>
[JsonPropertyName("entries")]
public IReadOnlyList<SignRequest>? Entries { get; set; } = default;
Expand Down
2 changes: 1 addition & 1 deletion Box.Sdk.Gen/Schemas/TemplateSigner/TemplateSigner.cs
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public class TemplateSigner {
/// <summary>
/// If provided, this value points signers that are assigned the same inputs and belongs to same signer group.
/// A signer group is not a Box Group. It is an entity that belongs to the template itself and can only be used
/// within Sign Requests created from it.
/// within Box Sign requests created from it.
/// </summary>
[JsonPropertyName("signer_group_id")]
public string? SignerGroupId { get; set; } = default;
Expand Down
40 changes: 20 additions & 20 deletions docs/SignRequests.md
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
# ISignRequestsManager


- [Cancel sign request](#cancel-sign-request)
- [Resend sign request](#resend-sign-request)
- [Get sign request by ID](#get-sign-request-by-id)
- [List sign requests](#list-sign-requests)
- [Create sign request](#create-sign-request)
- [Cancel Box Sign request](#cancel-box-sign-request)
- [Resend Box Sign request](#resend-box-sign-request)
- [Get Box Sign request by ID](#get-box-sign-request-by-id)
- [List Box Sign requests](#list-box-sign-requests)
- [Create Box Sign request](#create-box-sign-request)

## Cancel sign request
## Cancel Box Sign request

Cancels a sign request.

Expand All @@ -24,7 +24,7 @@ await client.SignRequests.CancelSignRequestAsync(signRequestId: NullableUtils.Un
### Arguments

- signRequestId `string`
- The ID of the sign request Example: "33243242"
- The ID of the signature request Example: "33243242"
- headers `CancelSignRequestHeaders`
- Headers of cancelSignRequest method
- cancellationToken `System.Threading.CancellationToken?`
Expand All @@ -38,9 +38,9 @@ This function returns a value of type `SignRequest`.
Returns a Sign Request object.


## Resend sign request
## Resend Box Sign request

Resends a sign request email to all outstanding signers.
Resends a signature request email to all outstanding signers.

This operation is performed by calling function `ResendSignRequest`.

Expand All @@ -52,7 +52,7 @@ See the endpoint docs at
### Arguments

- signRequestId `string`
- The ID of the sign request Example: "33243242"
- The ID of the signature request Example: "33243242"
- headers `ResendSignRequestHeaders`
- Headers of resendSignRequest method
- cancellationToken `System.Threading.CancellationToken?`
Expand All @@ -67,7 +67,7 @@ Returns an empty response when the API call was successful.
The email notifications will be sent asynchronously.


## Get sign request by ID
## Get Box Sign request by ID

Gets a sign request by ID.

Expand All @@ -84,7 +84,7 @@ await client.SignRequests.GetSignRequestByIdAsync(signRequestId: NullableUtils.U
### Arguments

- signRequestId `string`
- The ID of the sign request Example: "33243242"
- The ID of the signature request Example: "33243242"
- headers `GetSignRequestByIdHeaders`
- Headers of getSignRequestById method
- cancellationToken `System.Threading.CancellationToken?`
Expand All @@ -95,13 +95,13 @@ await client.SignRequests.GetSignRequestByIdAsync(signRequestId: NullableUtils.U

This function returns a value of type `SignRequest`.

Returns a sign request
Returns a signature request.


## List sign requests
## List Box Sign requests

Gets sign requests created by a user. If the `sign_files` and/or
`parent_folder` are deleted, the sign request will not return in the list.
Gets signature requests created by a user. If the `sign_files` and/or
`parent_folder` are deleted, the signature request will not return in the list.

This operation is performed by calling function `GetSignRequests`.

Expand Down Expand Up @@ -130,10 +130,10 @@ This function returns a value of type `SignRequests`.
Returns a collection of sign requests


## Create sign request
## Create Box Sign request

Creates a sign request. This involves preparing a document for signing and
sending the sign request to signers.
Creates a signature request. This involves preparing a document for signing and
sending the signature request to signers.

This operation is performed by calling function `CreateSignRequest`.

Expand All @@ -159,6 +159,6 @@ await client.SignRequests.CreateSignRequestAsync(requestBody: new SignRequestCre

This function returns a value of type `SignRequest`.

Returns a Sign Request object.
Returns a Box Sign request object.


0 comments on commit 69187fe

Please sign in to comment.