chore(deps): Allow thecodingmachine/safe v3 #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theofidry
force-pushed
the
chore/tcm-safe
branch
from
1c95ed3 to
f283100
Compare
|
BOX 4.6.3 PHAR distribution ( Box version 4.6.3@9ec22a4 2025-02-19 20:32:43 UTC) still raises lot of deprecated errors. I.e: Running on PHP 8.4.4 platform |
OskarStark
reviewed
Feb 20, 2025
| @@ -41,7 +41,7 @@ | |||
| "symfony/polyfill-mbstring": "^1.28", | |||
| "symfony/process": "^6.4.0 || ^7.0.0", | |||
| "symfony/var-dumper": "^6.4.0 || ^7.0.0", | |||
| "thecodingmachine/safe": "^2.5", | |||
| "thecodingmachine/safe": "^2.5 || 3.0", | |||
There was a problem hiding this comment.
Thanks Oskar to point this constraint to our attention, but the solution is more easy and better !
@theofidry You've just to fix the constraint like this (because there are two bug releases following initial 3.0)
"thecodingmachine/safe": "^2.5 || ^3.0",There was a problem hiding this comment.
Oh indeed, I dod not see the missing ^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.