Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Php8.4 support #1447

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Php8.4 support #1447

wants to merge 5 commits into from

Conversation

SRWieZ
Copy link

@SRWieZ SRWieZ commented Feb 12, 2025

Fixes #1423

  • Added thecodingmachine/safe ^3.0 support
  • Bumbed symfony/process to 6.4.14 and 7.1.7 to pass CVE-2024-51736
  • Added 8.4 in tests and e2e tests

@SRWieZ
Copy link
Author

SRWieZ commented Feb 12, 2025

Hi, this is my first time contributing to this project, so please excuse any mistakes.

I did my best to ensure the tests pass, but there is a lot going on, and some things seem unrelated.

I noticed that thecodingmachine/safe tagged version 3.0, which addresses many deprecation notices, so I decided to give it a try.

Based on my results, we still need to support version 3.0 in your other packages:

➜  fork-box git:(php8.4-support) ✗ composer why thecodingmachine/safe
humbug/box        4.x-dev requires thecodingmachine/safe (^2.5 || ^3.0)
fidry/console     0.6.10  requires thecodingmachine/safe (^2.0)
fidry/filesystem  1.2.1   requires thecodingmachine/safe (^2.0)
fidry/makefile    1.0.2   requires thecodingmachine/safe (^2.0)
humbug/php-scoper 0.18.16 requires thecodingmachine/safe (^2.0)

If I'm on the right path, I can make a PR to the other four projects.

Thanks in advance for any feedback.

@theofidry
Copy link
Member

Thanks for the PR! I'll have a closer look this weekend unfortunately the last weeks have been very busy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PHP 8.4 support] and thecodingmachine/safe package
2 participants