Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable rendering bootstrap source #335

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

vyaghras
Copy link
Contributor

@vyaghras vyaghras commented Jan 2, 2025

Issue number:

Closes #

Description of changes:
Add a option in Bootstrap-containers binary to render the source for the Bootstrap container when unavailable. We will use the provided source if it is present.

Testing done:
Testing done:

  • Should be able run a bootstrap container with default Bootstrap container image for AWS variants.
  • Should be able run a bootstrap container with default Bootstrap container image for VMware and Metal variants.
  • Should use the provided bootstrap container image if the image URI has been provided in user-data.
  • One without source should use the default Bootstrap container and another with the given source should use that source.
  • The bootstrap containers should not be changed to strong if we pass enabled and other bootstrap container settings from userdata or apiclient set
  • Upgrade/Downgrade migration with the version containing default Bootstrap container.
  • Upgrade/Downgrade migration for Bootstrap container version change.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

This binary will be called by default from Sundog to populate default
settings.

This binary will fetch the available Bootstrap container settings
and parse all the bootstrap container. If the source is not available,
it adds the default source for that Bootstrap container else uses the
source provided.
@vyaghras vyaghras marked this pull request as draft January 2, 2025 19:03
@vyaghras
Copy link
Contributor Author

vyaghras commented Jan 2, 2025

This change is blocked by #294 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant