Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stale-issue-cleanup version update #4418

Closed
wants to merge 0 commits into from

Conversation

alikulka
Copy link

The action points to the latest release version tag instead of the SHA.

@jonathan343
Copy link
Contributor

Same question I have for #4419

Is there a reason we changed from using a SHAs to tags?

Using SHAs
If you need more reliable versioning, you should use the SHA value associated with the version of the action. SHAs are immutable and therefore more reliable than tags or branches.

Source: https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/using-pre-written-building-blocks-in-your-workflow#using-shas

@kellertk
Copy link
Contributor

While you are correct that humans don't change the SHAs, Dependabot can and does. The SHA that you have been using is pointing to the main branch of the action, and Dependabot has been cutting you PRs to update that SHA to the latest every time we make an update to main.

So far, you've been accepting these PRs, but we use semantically-versioned release tags to prevent inadvertent breakage on the main branch. This did cause both stale-issue-cleanup and closed-issue-message to break in this repository, because the tip of main was broken at one point but we had not cut a new release. For example:

I'm not aware of any additional testing you're doing to verify that these SHAs are OK to update. This sort of defeats the immutability that you seek. SHAs are immutable, but they're just getting updated anyway.

This week we made changes to our release cycle to automatically update the semantic tags whenever there's a new release possible, and more comprehensive tests to prevent merging broken code to main. This PR is to bring your repositories in line with all of the other AWS SDK team's instantiation of the actions.

@jonathan343
Copy link
Contributor

Got it, thanks for the clarification @kellertk!

I'll approve this PR.

@alikulka can you update #4419 to only include changes for aws-actions/closed-issue-message since there is some overlap between the two PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants