Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manager: Remove non-enrolled validators from peer list #3080

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

omerfirmak
Copy link
Contributor

@omerfirmak omerfirmak commented Feb 21, 2022

Will work both when a validator is no longer enrolled or changes
its stake.

@omerfirmak
Copy link
Contributor Author

Fixes #2868

@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #3080 (942757b) into v0.x.x (fd69651) will increase coverage by 0.33%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           v0.x.x    #3080      +/-   ##
==========================================
+ Coverage   79.02%   79.35%   +0.33%     
==========================================
  Files         209      210       +1     
  Lines       18723    18845     +122     
==========================================
+ Hits        14796    14955     +159     
+ Misses       3927     3890      -37     
Flag Coverage Δ
integration 27.70% <85.71%> (+8.06%) ⬆️
unittests 87.39% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/agora/network/Manager.d 83.77% <100.00%> (+1.00%) ⬆️
source/agora/node/FullNode.d 77.46% <100.00%> (+2.86%) ⬆️
source/agora/node/Validator.d 94.08% <100.00%> (+0.57%) ⬆️
source/agora/test/Quorum.d 96.00% <100.00%> (ø)
source/agora/test/RestoreSlashingInfo.d 93.33% <100.00%> (+0.22%) ⬆️
source/agora/test/ValidatorRecurringEnrollment.d 94.68% <100.00%> (+0.05%) ⬆️
source/agora/network/Client.d 81.67% <0.00%> (-3.82%) ⬇️
source/agora/consensus/protocol/Nominator.d 90.87% <0.00%> (-0.85%) ⬇️
source/agora/consensus/state/Ledger.d 90.94% <0.00%> (-0.37%) ⬇️
source/agora/script/Engine.d 97.59% <0.00%> (-0.16%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd69651...942757b. Read the comment docs.

@omerfirmak omerfirmak force-pushed the update-peer-list branch 4 times, most recently from b8a62b0 to c4b7137 Compare February 23, 2022 10:54
Will work both when a validator is no longer enrolled or changes
its stake.
@omerfirmak
Copy link
Contributor Author

green

Copy link
Contributor

@hewison-chris hewison-chris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement peer re-negotiation
3 participants