Stop nominating immediately after externalize #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v0.x.x #1365 +/- ##
==========================================
- Coverage 78.30% 78.29% -0.02%
==========================================
Files 108 108
Lines 9026 9026
==========================================
- Hits 7068 7067 -1
- Misses 1958 1959 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Geod24
reviewed
Nov 13, 2020
source/agora/node/Validator.d
Outdated
Comment on lines
360
to
362
| super.onAcceptedBlock(block, validators_changed); | ||
|
|
There was a problem hiding this comment.
Wouldn't this be better after the assert ?
The super call to `onAcceptedBlock()` can actually cause a context switch, which means the call to `stopNominationRound()` may be delayed.
AndrejMitrovic
force-pushed
the
dont-switch
branch
from
1352f61
to
bb17e26
Compare
|
I moved it below the assert. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a potential for a context switch here.
I'm not sure if this is related to #1364, but it's definitely a bug. We'll test it with #1364 next week.