Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link posts #90

Closed
wants to merge 5 commits into from
Closed

Link posts #90

wants to merge 5 commits into from

Conversation

jmglov
Copy link
Contributor

@jmglov jmglov commented Feb 4, 2024

Please answer the following questions and leave the below in as part of your PR.

@jmglov
Copy link
Contributor Author

jmglov commented Feb 5, 2024

@borkdude I need to do a little bit of testing around how this interacts with caching, so please hold off on merging for now. I'll let you know when everything looks good. :)

@borkdude
Copy link
Owner

borkdude commented Feb 5, 2024

Cool! One thing to note about the keyword + question mark: https://twitter.com/borkdude/status/1754472619783454947

@jmglov
Copy link
Contributor Author

jmglov commented Feb 5, 2024

Interesting point. I'll make some changes there.

@jmglov
Copy link
Contributor Author

jmglov commented Feb 15, 2024

I found a much less intrusive way to do this. 🙂

I'll open a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants