Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/loglink moved below logs table #1939

Merged
merged 5 commits into from
Feb 21, 2024

Conversation

shivansh02
Copy link
Collaborator

Moved the complete logs link from about tab to below logs table.

Description

Removed the link from about tab and added it below logs table on the schedule tab.

Related Issue

#1862

Motivation and Context

Schedule->Logs is a better location for the link, so that one can view the complete logs in case the ones in the summary aren't enough.

How Has This Been Tested?

Tested by me locally.

Screenshots (if appropriate):

Screenshot from 2024-02-17 19-47-53
Screenshot from 2024-02-17 19-47-41

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING guide.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.

@real-yfprojects
Copy link
Collaborator

Maybe keep the link also in the about tab for backwards compatibility?

@shivansh02
Copy link
Collaborator Author

Added the link back to the about tab, please take a look.

@m3nu
Copy link
Contributor

m3nu commented Feb 20, 2024

Didn't run it locally, but looks fine. Also doesn't change up all the UI files. Will merge tomorrow after testing locally.

Copy link
Contributor

@diivi diivi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Works for me too.

@m3nu m3nu merged commit b2cf5b1 into borgbase:master Feb 21, 2024
11 checks passed
@m3nu
Copy link
Contributor

m3nu commented Feb 21, 2024

Fixes #1862

@m3nu
Copy link
Contributor

m3nu commented Feb 21, 2024

Thanks for contributing! Active community members like yourself ensure the quality and relevance of this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants