Fix borgbackup unable to find packaging dependency #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I already ran the new workflow on my fork of the repository: https://github.com/fasmat/homebrew-tap/actions/runs/11796653094/job/32858979797 Seems to be working well now 🙂, sorry for committing and pushing so often 😅 |
|
LGTM, @m3nu can you review? |
|
Looks good. Uses newer homebrew and GH Action commands. |
This was referenced Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #36, #38 and #27
I updated the formula with the changes from the official homebrew repository adding the missing
packagingdependency. Additionally I updated the CI workflow to test that the formula can be installed, uninstalled and used to create a backup via the formulastestmethod.