repository.list: refresh lock more frequently #8394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
under all circumstances, we must avoid that the lock gets stale due to not being refreshed in time. there is some internal rate limiting in _lock_refresh, so calling it often should be no problem.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8394 +/- ##
=======================================
Coverage 81.57% 81.57%
=======================================
Files 70 70
Lines 12700 12700
Branches 2298 2298
=======================================
Hits 10360 10360
Misses 1688 1688
Partials 652 652 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
under all circumstances, we must avoid that the lock gets stale due to not being refreshed in time.
there is some internal rate limiting in _lock_refresh, so calling it often should be no problem.
fixes #8390.