Remove optional dependency on filesystem when not meant to be #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build previously failed when BOOST_PROCESS_USE_STD_FS was ON, because filesystem was linked to regardless.
SimonMaracine
force-pushed
the
develop
branch
from
5d042dd to
e77b2f3
Compare
|
I am very sorry. I just noticed that I have made the commit in the I think it's better to just close this pull request and someone else make the change manually. |
|
You pushed to your develop branch, that's fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build previously failed when BOOST_PROCESS_USE_STD_FS was ON, because filesystem was linked to regardless.
I tried to use this library with the std version of filesystem and I noticed that Boost::filesystem was listed as a dependency regardless of the flag. I'm pretty sure this is just a little mistake.