Various minor improvements #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barendgehrels
commented
Sep 14, 2023
| @@ -27,6 +27,7 @@ | |||
| #include <boost/range/begin.hpp> | |||
| #include <boost/range/end.hpp> | |||
| #include <boost/range/value_type.hpp> | |||
| #include <boost/range/size.hpp> | |||
There was a problem hiding this comment.
After updating Boost to the most recent develop on my notebook (because of swap), this missing include was problematic for some unit tests, which is the reason why I checked all usages.
There was a problem hiding this comment.
indeed, this is caught by github actions too, which is still failing after the modifications of this PR.
This was referenced Sep 14, 2023
vissarion
reviewed
Sep 25, 2023
barendgehrels
force-pushed
the
various-minor-improvements
branch
from
39fb0ab
to
30d26fe
Compare
For me it did not fail. But I added the include there too and it should now be fine. Thank you. |
barendgehrels
force-pushed
the
various-minor-improvements
branch
from
30d26fe
to
9f9b24f
Compare
|
Now all tests pass. @vissarion could you approve? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1169
Adds unit tests for issue #1138 which was already fixed
Adds unit test for issue #1103 which was already fixed
Adds comments for epsilon as suggested by @vissarion
And some stylistic issues (const placements, includes)