Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace virtual with override in exception::what() #1198

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Replace virtual with override in exception::what() #1198

merged 2 commits into from
Sep 13, 2023

Conversation

georgthegreat
Copy link
Contributor

@georgthegreat georgthegreat commented Sep 8, 2023 •
edited
Loading

As promised in #1191

@georgthegreat
Copy link
Contributor Author

@vissarion, could you, please, take a look?

vissarion
vissarion approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@vissarion vissarion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you please separate in two commits (one for main library and one for extensions)?

@georgthegreat
Copy link
Contributor Author

@vissarion done with splitting.

@barendgehrels barendgehrels merged commit ac9d88d into boostorg:develop Sep 13, 2023
22 of 23 checks passed
@vissarion vissarion added this to the 1.84 milestone Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vissarion vissarion vissarion approved these changes

@barendgehrels barendgehrels barendgehrels approved these changes

@awulkiew awulkiew Awaiting requested review from awulkiew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.84
Development

Successfully merging this pull request may close these issues.
3 participants
@georgthegreat @barendgehrels @vissarion