Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration branch for PR #1267 #1278

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Integration branch for PR #1267 #1278

wants to merge 4 commits into from

Conversation

javiertoledo
Copy link
Member

Description

Integration for PR #1267

Changes

Checks

  • Project Builds
  • Project passes tests and checks
  • Updated documentation accordingly

nicolatl and others added 4 commits December 7, 2022 21:24
@nicolatl
fix(unittests): make unittests pass on Windows per issue #538
59a5782 
fix timeout and macOS-style path assertion blocking test 13

fix cli tests with path.join

refactor aws-infrastructure fix to use path.join for consistency

fix to make script file path compatible with windows sep

fix azure infra test for windows

refactor env var set to cross env to work on all platforms

refactor env var set to cross-env for all cases
@nicolatl
refactor path.join to path.normalize where applicable
a960e8c
@nicolatl
perf: undo aws-infrastructure timeout change
bf71ab6 
Co-authored-by: Javier Toledo <[email protected]>
Merge pull request #1267 from nicolatl/fix/538_make-unittests-pass-on…
d31d093 
…-windows

fix(unittests): make unittests pass on Windows per issue #538
@what-the-diff
Copy link

what-the-diff bot commented Dec 14, 2022

  • Added cross-env to the test script in package.json
  • Fixed paths for new command tests
  • Added path module to project.test.ts
  • Normalized paths in project test file
  • Fixed tests for read-model command and scheduled-command commands
  • Fixing the path.normalize() in all tests
  • Adding cross-env to test script for windows compatibility
  • The test script was changed to use cross-env instead of BOOSTER_ENV=test
  • A new dependency, "cross-env", was added in both packages/framework-provider-local and packages/framework-provider-local infrastructure

@javiertoledo javiertoledo self-assigned this Dec 14, 2022
@ghost
Copy link

ghost commented Dec 14, 2022

👇 Click on the image for a new way to code review

  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@javiertoledo javiertoledo changed the title Integration for PR #1267 Integration branch for PR #1267 Dec 14, 2022
@NickSeagull
Copy link
Member

/integration sha=d31d093

@github-actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@github-actions
Copy link
Contributor

❌ Oh no! Integration tests have failed

@javiertoledo javiertoledo mentioned this pull request Sep 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@javiertoledo javiertoledo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@javiertoledo @NickSeagull @nicolatl