feat: LayoverConstraintWrapper 구현 #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
chopmozzi
approved these changes
Nov 21, 2023
Comment on lines
30
to
32
| func bottomAnchor(equalTo anchor: NSLayoutYAxisAnchor, constant: CGFloat = 0) { | ||
| view.bottomAnchor.constraint(equalTo: anchor, constant: constant).isActive = true | ||
| } |
|
이건 우선 순위 낮춰서 나중에 더 구현할게요 :) |
WhiteHyun
reviewed
Nov 24, 2023
Comment on lines
+12
to
+16
|
|
||
| func makeConstraints(_ closure: (ConstraintMaker) -> Void) { | ||
| base.translatesAutoresizingMaskIntoConstraints = false | ||
| closure(ConstraintMaker(base)) | ||
| } |
There was a problem hiding this comment.
updateConstraints도 구현해주세요..
나중에 갖다 써야지..ㅎ
|
벌써 1년이네요... |
|
@chopmozzi 지켜보고있다... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧑🚀 PR 요약
오토레이아웃을 편리하게 작성할 수 있는 extension wrapper를 구현했습니다.
완전 Snapkit...처럼은 아니지만 어느정도 컨셉은 비슷하게 ^^;; 구현해보려고 노력했습니다.
전부 다 구현한 건 아니고 필요한 메서드는 ConstraintMaker에 구현해주시면 될 것 같아요.
우선은 생각나는 메서드만 구현해봤습니다.
예시는 Home 셀에 적용해보았습니다. lor 네임스페이스로 접근하셔서 사용하심 될 듯 합니다.
근데 SnapKit 처럼 만드는 건 어떻게 해야 할까요? 얼핏 봤을때는 ConstraintItem 타입으로 인자가 들어오는 것 같았는데...
많은 지적 부탁드립니다.
Linked Issue
close #49