Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

아티스트 삭제 #371

Merged
merged 4 commits into from
Jan 11, 2024
Merged

아티스트 삭제 #371

merged 4 commits into from
Jan 11, 2024

Conversation

khw3754
Copy link
Collaborator

@khw3754 khw3754 commented Jan 11, 2024

Issue

Overview

  • soft delete 를 위해 is_deleted 열 추가
  • user 조회시 is_deleted 검증 추가
  • jwt strategy 수정

Screenshot

  • 탈퇴 후 API 호출
image

khw3754 and others added 4 commits January 11, 2024 14:29
@khw3754 @sk000801
feat : is_deleted 열 추가
53e6350 
* soft delete 를 위한 열 추가

Co-authored-by: Cutiepazzipozzi <[email protected]>
@khw3754 @sk000801
feat : jwt strategy 수정
93b1254 
* is_deleted 열 검증 추가

Co-authored-by: Cutiepazzipozzi <[email protected]>
@khw3754 @sk000801
feat : user 조회 쿼리문 수정
01a8ec8 
* 조회시 is_deleted 검증 추가

Co-authored-by: Cutiepazzipozzi <[email protected]>
@khw3754
chore : 오타 수정
ee818e5
@khw3754 khw3754 added ✨ feat 기능 개발 🖥 server server labels Jan 11, 2024
@khw3754 khw3754 added this to the 🧑‍🎨 artist milestone Jan 11, 2024
@khw3754 khw3754 requested a review from sk000801 as a code owner January 11, 2024 05:57
@khw3754 khw3754 self-assigned this Jan 11, 2024
@khw3754 khw3754 linked an issue Jan 11, 2024 that may be closed by this pull request
아티스트 삭제 #355
Closed
sk000801
sk000801 approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@sk000801 sk000801 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guard 단에서 탈퇴한 user가 걸러지도록 고려한게 신의 한 수인것 같아요!
페어 프로그래밍 했으니 approve 할게요!!! 고생하셨습니다 👍👍

@khw3754 khw3754 merged commit cabee91 into develop Jan 11, 2024
1 check passed
@khw3754 khw3754 deleted the server/feature/355 branch January 11, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sk000801 sk000801 sk000801 approved these changes

Assignees

@sk000801 sk000801

@khw3754 khw3754

Labels
✨ feat 기능 개발 🖥 server server
Projects
None yet
Milestone
🧑‍🎨 artist
Development

Successfully merging this pull request may close these issues.

아티스트 삭제
2 participants
@khw3754 @sk000801