Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CurrentPlaylistUseCase 리팩토링 #350

Merged
merged 1 commit into from
Jan 15, 2024
Merged

CurrentPlaylistUseCase 리팩토링 #350

merged 1 commit into from
Jan 15, 2024

Conversation

HamBP
Copy link
Member

@HamBP HamBP commented Dec 19, 2023

Issue

Overview

  • CurrentPlaylistUseCase에서 CoroutineScope 제거

@HamBP HamBP self-assigned this Dec 19, 2023
@HamBP HamBP added 🛠️ refactor 리팩토링 🤖 android android labels Dec 19, 2023
@HamBP HamBP added this to the ⏯️ playlist milestone Dec 19, 2023
@HamBP HamBP linked an issue Dec 19, 2023 that may be closed by this pull request
Copy link

Test Results

6 tests   6 ✔️  1s ⏱️
2 suites  0 💤
2 files    0

Results for commit 9981c93.

Copy link
Collaborator

@2taezeat 2taezeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~

하신 작업이 말그대로, 불필요한 scope를 제거하고, suspend로 변경하는 것으로 이해하면 될까요?
(내부 CoroutineScope를 제거하고 함수를 suspend로 변경한다. )

@HamBP
Copy link
Member Author

HamBP commented Jan 10, 2024

"UI 로직이 포함되어 있다"는 최종 발표 피드백이 있었는데, UI에 해당하는 부분이 Dispatchers.Main 부분이야. (코루틴 안드로이드가 메인 스레드를 Android의 Looper를 통해 가져오기 때문) 그래서 주 목적은 도메인에서 UI에 해당하는 로직 제거!

@HamBP HamBP merged commit c777192 into develop Jan 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CurrentPlaylistUseCase 리팩토링
2 participants