Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA에서 발견한 버그 개선 및 MyPage -> Player 이동 #339

Merged
merged 14 commits into from
Dec 14, 2023
Merged

QA에서 발견한 버그 개선 및 MyPage -> Player 이동 #339

merged 14 commits into from
Dec 14, 2023

Conversation

2taezeat
Copy link
Collaborator

@2taezeat 2taezeat commented Dec 13, 2023 •
edited
Loading

Issue

Overview

  • 플레이리스트 추가 bottom 짤리는 ui
  • Player에서 ‘저장’ 빠르게 두번 누르면, 앱 터짐
    • throttleFirst 사용
  • 화면 회전 금지
  • MyPage, MyMusics에서 노래 클릭시 해당 곡의 Player로 이동
  • 새 재생목록 추가 버튼 클릭 throttleFist 처리

Screenshot

스크린샷 2023-12-12 23 19 57

@2taezeat 2taezeat self-assigned this Dec 13, 2023
@2taezeat 2taezeat added this to the 🔧 etc milestone Dec 13, 2023
@2taezeat 2taezeat added ✨ feat 기능 개발 🐞 bug 버그 수정 🤖 android android labels Dec 13, 2023
@2taezeat 2taezeat linked an issue Dec 13, 2023 that may be closed by this pull request
QA에서 발견한 버그 개선 #338
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2023 •
edited
Loading

Test Results

6 tests   6 ✔️  1s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit baaf753.

♻️ This comment has been updated with latest results.

@2taezeat 2taezeat changed the title Android/hotfix/338 QA에서 발견한 버그 개선 Dec 13, 2023
@2taezeat 2taezeat linked an issue Dec 13, 2023 that may be closed by this pull request
MyPage에서 노래 클릭시 해당 곡의 Player로 이동 #340
Closed
@2taezeat 2taezeat changed the title QA에서 발견한 버그 개선 QA에서 발견한 버그 개선 및 MyPage -> Player 이동 Dec 13, 2023
HamBP
HamBP reviewed Dec 13, 2023
View reviewed changes
android/feature/player/src/main/java/com/ohdodok/catchytape/feature/player/PlayerFragment.kt Outdated
Comment on lines 75 to 78
clicksFlow(view = it).throttleFist(500)
.onEach {
findNavController().showPlaylistBottomSheet()
}.launchIn(viewLifecycleOwner.lifecycleScope)
Copy link
Member

@HamBP HamBP Dec 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 로직을 테스트한 방법이 궁금해
내 생각엔 각 클릭마다 개별 flow가 생기기 때문에 연속 클릭을 방지할 수 없을 것 같아

Copy link
Collaborator Author

@2taezeat 2taezeat Dec 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log 출력 및 에뮬레이터 로 확인하였습니다~

[reference]

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

한 번더 확인해보겠습니다~

Copy link
Collaborator Author

@2taezeat 2taezeat Dec 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

View 확장 함수로 변경 및 개선하였습니다!

HamBP
HamBP approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@HamBP HamBP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨어용

youlalala
youlalala approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@youlalala youlalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

버그 수정하느라 고생이시군요! 고생하셨습니다!!

@2taezeat 2taezeat merged commit 72c421b into develop Dec 14, 2023
2 checks passed
@2taezeat 2taezeat deleted the android/hotfix/338 branch December 14, 2023 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youlalala youlalala youlalala approved these changes

@HamBP HamBP HamBP approved these changes

Assignees

@2taezeat 2taezeat

Labels
🤖 android android 🐞 bug 버그 수정 ✨ feat 기능 개발
Projects
None yet
Milestone
🔧 etc
Development

Successfully merging this pull request may close these issues.

MyPage에서 노래 클릭시 해당 곡의 Player로 이동 QA에서 발견한 버그 개선
3 participants
@2taezeat @HamBP @youlalala