검색 - 키워드 입력 #266
Merged
검색 - 키워드 입력 #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-catchy-tape into android/feature/30
Closed
2taezeat
approved these changes
Dec 5, 2023
| android:layout_width="match_parent" | ||
| android:layout_height="match_parent"> | ||
|
|
||
| <EditText |
There was a problem hiding this comment.
검색 UI 구현할때,
com.google.android.material.search.SearchView 을 쓰지 않은 이유가 있으신가요? (궁금해서 여쭤봅니다)
There was a problem hiding this comment.
SearchView보다 EditText를 커스텀하는 게 더 쉬울 거라 생각했어
youlalala
reviewed
Dec 5, 2023
Comment on lines
23
to
24
| android:text="@{viewModel.uiState.keyword}" | ||
| android:onTextChanged="@{(text, s, b, c) -> viewModel.updateKeyword(text.toString())}" |
There was a problem hiding this comment.
텍스트가 바뀌면 viewmodel에 업데이트 하고 또 viewmodel에서 업데이트 된 텍스트를 text에 넣는 것 같은데, 위에 android:text="@{viewModel.uiState.keyword}" 는 없어도 될 것 같슴다
There was a problem hiding this comment.
ViewModel에서 text를 조작하는 경우를 고려한 코드긴 한데, 일단 제거하고 올릴게!
혹시나 테스트 해봤는데 무한 루프는 안 생기는 거 같아
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview
Screenshot