내가 업로드한 노래 전체 보기 #225
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| package com.ohdodok.catchytape.feature.mypage | ||
|
|
||
| import android.os.Bundle | ||
| import android.view.View | ||
| import androidx.fragment.app.viewModels | ||
| import com.ohdodok.catchytape.core.ui.BaseFragment | ||
| import com.ohdodok.catchytape.core.ui.MusicAdapter | ||
| import com.ohdodok.catchytape.core.ui.Orientation | ||
| import com.ohdodok.catchytape.core.ui.toMessageId | ||
| import com.ohdodok.catchytape.feature.mypage.databinding.FragmentMyMusicsBinding | ||
| import dagger.hilt.android.AndroidEntryPoint | ||
|
|
||
| @AndroidEntryPoint | ||
| class MyMusicsFragment : BaseFragment<FragmentMyMusicsBinding>(R.layout.fragment_my_musics) { | ||
| private val viewModel: MyMusicsViewModel by viewModels() | ||
|
|
||
| override fun onViewCreated(view: View, savedInstanceState: Bundle?) { | ||
| super.onViewCreated(view, savedInstanceState) | ||
| binding.viewModel = viewModel | ||
|
|
||
| setupRecyclerView() | ||
| observeEvents() | ||
| setupBackStack(binding.tbMyMusics) | ||
| } | ||
|
|
||
| private fun setupRecyclerView() { | ||
| binding.rvMyMusics.adapter = MusicAdapter(Orientation.VERTICAL) | ||
| } | ||
|
|
||
| private fun observeEvents() { | ||
| repeatOnStarted { | ||
| viewModel.events.collect { event -> | ||
| when (event) { | ||
| is MyMusicsEvent.ShowMessage -> { | ||
| showMessage(event.error.toMessageId()) | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| package com.ohdodok.catchytape.feature.mypage | ||
|
|
||
| import androidx.lifecycle.ViewModel | ||
| import androidx.lifecycle.viewModelScope | ||
| import com.ohdodok.catchytape.core.domain.model.CtErrorType | ||
| import com.ohdodok.catchytape.core.domain.model.CtException | ||
| import com.ohdodok.catchytape.core.domain.model.Music | ||
| import com.ohdodok.catchytape.core.domain.repository.MusicRepository | ||
| import dagger.hilt.android.lifecycle.HiltViewModel | ||
| import kotlinx.coroutines.CoroutineExceptionHandler | ||
| import kotlinx.coroutines.flow.MutableSharedFlow | ||
| import kotlinx.coroutines.flow.MutableStateFlow | ||
| import kotlinx.coroutines.flow.SharedFlow | ||
| import kotlinx.coroutines.flow.StateFlow | ||
| import kotlinx.coroutines.flow.asSharedFlow | ||
| import kotlinx.coroutines.flow.asStateFlow | ||
| import kotlinx.coroutines.flow.launchIn | ||
| import kotlinx.coroutines.flow.onEach | ||
| import kotlinx.coroutines.flow.update | ||
| import kotlinx.coroutines.launch | ||
| import kotlinx.coroutines.plus | ||
| import javax.inject.Inject | ||
|
|
||
| data class MyMusicsUiState( | ||
| val myMusics: List<Music> = emptyList() | ||
| ) | ||
|
|
||
| sealed interface MyMusicsEvent { | ||
| data class ShowMessage( | ||
| val error: CtErrorType | ||
| ) : MyMusicsEvent | ||
| } | ||
|
|
||
| @HiltViewModel | ||
| class MyMusicsViewModel @Inject constructor( | ||
| private val musicRepository: MusicRepository, | ||
| ) : ViewModel() { | ||
|
|
||
| private val _uiState = MutableStateFlow(MyMusicsUiState()) | ||
| val uiState: StateFlow<MyMusicsUiState> = _uiState.asStateFlow() | ||
|
|
||
| private val _events = MutableSharedFlow<MyMusicsEvent>() | ||
| val events: SharedFlow<MyMusicsEvent> = _events.asSharedFlow() | ||
|
|
||
| private val exceptionHandler = CoroutineExceptionHandler { _, throwable -> | ||
| viewModelScope.launch { | ||
| val errorType = | ||
| if (throwable is CtException) throwable.ctError | ||
| else CtErrorType.UN_KNOWN | ||
|
|
||
| _events.emit(MyMusicsEvent.ShowMessage(errorType)) | ||
|
Comment on lines
+47
to
+51
|
||
| } | ||
| } | ||
|
|
||
| private val viewModelScopeWithExceptionHandler = viewModelScope + exceptionHandler | ||
|
|
||
| init { | ||
| fetchMyMusics() | ||
| } | ||
|
Comment on lines
+57
to
+59
There was a problem hiding this comment. 왜 init { } 에서 호출하는지, 알 수 있나요? There was a problem hiding this comment. MyPage는 onStart 시점에 호출하도록 변경했어 There was a problem hiding this comment. 제가 MyMusicsViewModel.kt 에서 호출 되는지 착각 했네요, 이 위치 맞습니다~ |
||
|
|
||
| private fun fetchMyMusics() { | ||
| musicRepository.getMyMusics() | ||
| .onEach { musics -> | ||
| _uiState.update { | ||
| it.copy(myMusics = musics) | ||
| } | ||
| } | ||
| .launchIn(viewModelScopeWithExceptionHandler) | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <layout xmlns:android="http://schemas.android.com/apk/res/android" | ||
| xmlns:app="http://schemas.android.com/apk/res-auto" | ||
| xmlns:tools="http://schemas.android.com/tools"> | ||
|
|
||
| <data> | ||
|
|
||
| <variable | ||
| name="viewModel" | ||
| type="com.ohdodok.catchytape.feature.mypage.MyMusicsViewModel" /> | ||
| </data> | ||
|
|
||
| <androidx.constraintlayout.widget.ConstraintLayout | ||
| android:layout_width="match_parent" | ||
| android:layout_height="match_parent"> | ||
|
|
||
| <com.google.android.material.appbar.MaterialToolbar | ||
| android:id="@+id/tb_my_musics" | ||
| android:layout_width="0dp" | ||
| android:layout_height="@dimen/appbar_height" | ||
| app:layout_constraintEnd_toEndOf="parent" | ||
| app:layout_constraintStart_toStartOf="parent" | ||
| app:layout_constraintTop_toTopOf="parent" | ||
| app:navigationIcon="@drawable/ic_arrow_back" | ||
| app:title="@string/my_musics" /> | ||
|
|
||
| <androidx.recyclerview.widget.RecyclerView | ||
| android:id="@+id/rv_my_musics" | ||
| android:layout_width="0dp" | ||
| android:layout_height="0dp" | ||
| android:clipToPadding="false" | ||
| android:paddingHorizontal="@dimen/margin_horizontal" | ||
| android:paddingTop="@dimen/large" | ||
| app:layoutManager="androidx.recyclerview.widget.LinearLayoutManager" | ||
| app:layout_constraintBottom_toBottomOf="parent" | ||
| app:layout_constraintEnd_toEndOf="parent" | ||
| app:layout_constraintStart_toStartOf="parent" | ||
| app:layout_constraintTop_toBottomOf="@id/tb_my_musics" | ||
| app:list="@{viewModel.uiState.myMusics}" | ||
| tools:listitem="@layout/item_music_vertical" /> | ||
|
|
||
| </androidx.constraintlayout.widget.ConstraintLayout> | ||
| </layout> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
emit 할때만, viewModelScope 이용하면 어떨까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
errorType이 viewModelScope.launch 안에 있는데, 이걸 viewModelScope.launch 바깥으로 빼자는 의미입니다~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
일단 고치긴 했는데 이유는 무엇인가요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
코루틴 안에서 할 필요가 없는 일을, 굳이 코루틴 안에서 하는게 이상하다는 것 이였습니다~