ts 파일 응답 API 구현 #218
Merged
ts 파일 응답 API 구현 #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 404 NOT_FOUND * 4010 : 버킷에 해당되는 ts 파일이 없음
* 다만 Buffer 형태로 제공되는데 클라이언트에서 어떻게 형태를 받아와야하는지에 따라 코드 수정 여지 있
Closed
khw3754
approved these changes
Nov 29, 2023
| throw new CatchyException( | ||
| 'NOT_EXIST_TS_IN_BUCKET', | ||
| HTTP_STATUS_CODE.NOT_FOUND, | ||
| ERROR_CODE.NOT_EXIST_TS_IN_BUCKET, |
There was a problem hiding this comment.
ERROR_CODE 상세해서 좋은 것 같아요!
There was a problem hiding this comment.
감사합니다! buffer는 안드분들이랑 얘기해보고 형태 괜찮으면 머지할게용!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview
musicId와청크파일이름.ts을 받아 GET 요청 보냄Screenshot
요청이 잘 들어갔을 때, 없는 ts 파일을 요청했을 때 (첫번째 사진은 해당 경로에 존재하는 파일 목록입니당)
To Reviewers
ts파일을 Buffer 형태로 반환하는게 맞는지 모르겠습니다.. 더 찾아봐야할 수도 있어요.. 🫠