Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

업로드 관련 버그 수정 #151

Merged
merged 2 commits into from
Nov 22, 2023
Merged

업로드 관련 버그 수정 #151

merged 2 commits into from
Nov 22, 2023

Conversation

sk000801
Copy link
Member

Issue

Overview

  • 서버 CD가 이루어질 때 업로드 관련 Pull Request에서 미처 빼지 못한 모듈이 있어 문제가 발생하여 이를 제거
  • uuid 형태의 string만 넘겨받기

@sk000801
chore : axios 관련 HttpModule 제거
494020b 
* 일부러 빼둔 axios 모듈을 이곳에서 넣어주어 CD에서 문제가 발생.
@sk000801
chore : 파일 업로드 시 uuid 패턴 검증 함수 추가
e22cff0
@sk000801 sk000801 added 🐞 bug 버그 수정 🖥 server server labels Nov 22, 2023
@sk000801 sk000801 added this to the 🆙 upload milestone Nov 22, 2023
@sk000801 sk000801 self-assigned this Nov 22, 2023
@sk000801 sk000801 requested a review from khw3754 as a code owner November 22, 2023 14:08
@sk000801 sk000801 linked an issue Nov 22, 2023 that may be closed by this pull request
Presigned URL 발급 #124
Closed
khw3754
khw3754 approved these changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@khw3754 khw3754 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

버그 수정 감사합니다!

@sk000801 sk000801 merged commit ac2cc69 into develop Nov 22, 2023
1 check passed
@sk000801 sk000801 deleted the server/fix/124 branch November 22, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khw3754 khw3754 khw3754 approved these changes

Assignees

@sk000801 sk000801

Labels
🐞 bug 버그 수정 🖥 server server
Projects
None yet
Milestone
🆙 upload
Development

Successfully merging this pull request may close these issues.

Presigned URL 발급
2 participants
@sk000801 @khw3754