Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

네트워크 연결 상태 확인 #148

Merged
merged 4 commits into from
Nov 22, 2023
Merged

네트워크 연결 상태 확인 #148

merged 4 commits into from
Nov 22, 2023

Conversation

HamBP
Copy link
Member

@HamBP HamBP commented Nov 22, 2023

Issue

Overview

다음 시나리오에서 "네트워크 연결을 확인해 주세요."라는 토스트를 띄운다.

  • 앱에 진입했는데, 네트워크 연결이 안 되어 있을 경우
  • 특정 네트워크를 잃었는데, 더 이상 연결 가능한 네트워크가 없을 경우

시나리오는 유튜브 뮤직을 테스트 해봤어

@HamBP HamBP added ✨ feat 기능 개발 🤖 android android labels Nov 22, 2023
@HamBP HamBP added this to the 🔧 etc milestone Nov 22, 2023
@HamBP HamBP self-assigned this Nov 22, 2023
@HamBP HamBP linked an issue Nov 22, 2023 that may be closed by this pull request
Copy link

Test Results

4 tests   4 ✔️  1s ⏱️
1 suites  0 💤
1 files    0

Results for commit 5b062c3.

Copy link
Member

@youlalala youlalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

login activity 에서는 네트워크 상태를 알 수 없나용?

Copy link
Collaborator

@2taezeat 2taezeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~

val isNetworkAvailable = capabilities?.hasCapability(NET_CAPABILITY_VALIDATED) ?: false

if (!isNetworkAvailable) {
Toast.makeText(this, getString(uiString.check_network), Toast.LENGTH_LONG).show()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

toast 대신 snackbar 어떠신가요??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저도 스낵바 좋아하는데요. 아직 스낵바 디자인을 안 해서 토스트로 했어요!

Copy link
Member

@youlalala youlalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생고생 하셨습니다~~

@HamBP HamBP merged commit d6715b4 into develop Nov 22, 2023
2 checks passed
@HamBP HamBP deleted the android/feature/110 branch November 30, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 android android ✨ feat 기능 개발
Projects
None yet
Development

Successfully merging this pull request may close these issues.

네트워크 연결 상태 확인
3 participants