[FE] 즐겨찾기 관련 레이아웃 구현 및 API 연동 #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannysir
reviewed
Nov 28, 2024
| <p | ||
| className={`w-1/4 truncate text-right ${+prdy_vrss_sign > 3 ? 'text-juga-blue-50' : 'text-juga-red-60'}`} | ||
| > | ||
| {prdy_ctrt}% |
There was a problem hiding this comment.
🟢여기도 +나 - 표시 하면 좋을 것 같아요
Comment on lines
+38
to
+52
| // const { debounceValue } = useDebounce(isBookmarked, 1000); | ||
| // const isInitialMount = useRef(true); | ||
|
|
||
| // useEffect(() => { | ||
| // if (isInitialMount.current) { | ||
| // isInitialMount.current = false; | ||
| // return; | ||
| // } | ||
|
|
||
| // if (debounceValue) { | ||
| // bookmark(code); | ||
| // } else { | ||
| // unbookmark(code); | ||
| // } | ||
| // }, [code, debounceValue]); |
There was a problem hiding this comment.
🟢아 여기에 사용하시려고 debounce를 변경하셨군요.
Comment on lines
+1
to
+23
| import { toast } from 'react-toastify'; | ||
|
|
||
| type ToastType = 'success' | 'error' | 'warning' | 'info'; | ||
|
|
||
| type ToastProps = { | ||
| message: string; | ||
| type: ToastType; | ||
| }; | ||
|
|
||
| export default function Toast({ message, type }: ToastProps) { | ||
| switch (type) { | ||
| case 'success': | ||
| return toast.success(message, { position: 'top-right', autoClose: 1000 }); | ||
| case 'error': | ||
| return toast.error(message, { position: 'top-right', autoClose: 1000 }); | ||
| case 'warning': | ||
| return toast.warning(message, { position: 'top-right', autoClose: 1000 }); | ||
| case 'info': | ||
| return toast.info(message, { position: 'top-right', autoClose: 1000 }); | ||
| default: | ||
| return null; | ||
| } | ||
| } |
There was a problem hiding this comment.
🟢 안그래도 토스트 관련으로 물어보려고 했는데 사용해 주셨군요 👍🏼
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 주요 작업
💭 고민과 해결과정
즐겨찾기 등록, 취소할 때 디바운스를 걸어 연속적인 호출을 하지 못하게 하려고 했다.
그래서 useEffect로 debouncedValue에 변화를 측정해 구현하려고 했지만 페이지가 렌더링될 때마다 즐겨찾기 취소가 되는 문제가 있었다.
명확한 이유를 찾지 못해 일단 즐겨찾기를 클릭할 때마다 등록/취소 api가 호출되도록 변경했다.
추후에 문제가 발생한 원인이 어떤 것인지 한 번 분석해봐야겠다.
close #212 #213 #214 #215 #216 #217