내용 작성 화면 Compose 전환 #170
Merged
내용 작성 화면 Compose 전환 #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eoeo0326
approved these changes
Jul 10, 2023
Comment on lines
+182
to
+191
| @Composable | ||
| fun UploadFilmTopArea( | ||
| writingState: Boolean, | ||
| muteState: Boolean, | ||
| backAction: () -> Unit, | ||
| uploadAction: () -> Unit, | ||
| muteAction: () -> Unit, | ||
| editTextAction: () -> Unit, | ||
| modifier: Modifier = Modifier | ||
| ) { |
junhyeongleeee
approved these changes
Jul 13, 2023
|
|
||
| Box(modifier = modifier) { | ||
| val muteAnimatable = rememberLottieAnimatable() | ||
| LaunchedEffect(muteState) { |
There was a problem hiding this comment.
muteState 랑 LottieClipSpec.Progress를 stateHolder로 묶어서 쓰면 관리하기도 좋고 유연성도 높아지더라고.
괜찮은지 확인 한번 해줘!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 내용
UploadFilmViewModel로 관리하던 데이터들 대부분Flow로 리팩토링ExoPlayer-> Compose에서AndroidView로 구현 및Lifecycle에 맞게 작동하도록 구현UploadFilmComposeActivity에서 실행하도록 구현SpannableString과 최대한 유사하게 보이도록 구현 (외부 라이브러리 활용)merge시 고려사항
primaryVariant색상blackBlur로 변경했음고민 중인 부분
LaunchedEffect사용이 적절한 상황이 언젠지 정확히는 모르겠음Resolve: #161